Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to add new codes for file access modes in (advanced/file_handling.py) #116

Closed
izumigoto opened this issue Oct 22, 2023 · 4 comments
Closed

Comments

@izumigoto
Copy link

izumigoto commented Oct 22, 2023

Hey there! @huangsam
python file handling expands not only to text files but binary and csv files too! and many more - a important feature of python which can scrap data across different files. and that's why the the knowledge to know about all the file handling modes in python makes the learner more of a prominent coder.

Hence i would like to contribute to (advanced/file_handling.py) inserting r+(read and write),w+(write and read),a+(append and read),binary file modes rb,wb,rb,rb+,wb+ etc and the same for csv files with these modes
thanks

@izumigoto izumigoto changed the title adding new codes for file access modes in (advanced/file_handling.py) for adding new codes for file access modes in (advanced/file_handling.py) Oct 22, 2023
@izumigoto izumigoto changed the title for adding new codes for file access modes in (advanced/file_handling.py) to adding new codes for file access modes in (advanced/file_handling.py) Oct 22, 2023
@izumigoto izumigoto changed the title to adding new codes for file access modes in (advanced/file_handling.py) to addnew codes for file access modes in (advanced/file_handling.py) Oct 22, 2023
@izumigoto izumigoto changed the title to addnew codes for file access modes in (advanced/file_handling.py) to add new codes for file access modes in (advanced/file_handling.py) Oct 22, 2023
@huangsam
Copy link
Owner

@izumigoto you're welcome to contribute back to the code. I look forward to seeing your PR

@izumigoto
Copy link
Author

@huangsam heyo kinda new to open source contribution
could you please provide info on why am i getting a error on my PR.

@huangsam
Copy link
Owner

Consider reading the logs of the CircleCI build to get more insights. You can see that the particular build failed on flake8 lint rules: https://app.circleci.com/pipelines/github/huangsam/ultimate-python/794/workflows/48a5b4f4-ae52-4a56-9ec2-4d6539c70ebd/jobs/800

@huangsam
Copy link
Owner

Closing #118 as I sense the thing that could have been done in that case is just adding more docstring content about the different modes. If you still find this issue to be interesting, please reopen this. Thanks again for contributing to Ultimate Python!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants