Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formatted smarts observations #1866

Open
9 tasks
Gamenot opened this issue Feb 14, 2023 · 0 comments
Open
9 tasks

Support formatted smarts observations #1866

Gamenot opened this issue Feb 14, 2023 · 0 comments
Labels
enhancement New feature or request
Projects

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Feb 14, 2023

Is your feature request related to a problem? Please describe.
The SMARTS observations cannot quite convert to proper observations.

Describe the solution you'd like

  • Ensure that the SMARTS observations convert to the following primitives
    • tuple/namedtuple
    • numpy.ndarray
    • dict
    • int, float, bool
    • fixed length str
  • Output the space matching the observation
  • Set the str length limits
  • Update the formatter options to allow this type of formatting.
@Gamenot Gamenot added the enhancement New feature or request label Feb 14, 2023
@Gamenot Gamenot added this to To do in SMARTS v1.2 via automation Feb 14, 2023
@Gamenot Gamenot moved this from To do to Medium Priority in SMARTS v1.2 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
SMARTS v1.2
Medium Priority
Development

No branches or pull requests

1 participant