Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized SMARTS service for MAD co-sim #403

Closed
liamchzh opened this issue Jan 12, 2021 · 2 comments
Closed

Customized SMARTS service for MAD co-sim #403

liamchzh opened this issue Jan 12, 2021 · 2 comments
Labels

Comments

@liamchzh
Copy link
Contributor

liamchzh commented Jan 12, 2021

A simple SMARTS service has been implemented


Motivations

  1. Communicate with SMARTS

    • Manage the process
    • Supply with different scenarios
    • Pause/stop/start/reset
  2. Easy setup (an environment to run SMARTS)

    • A MVS (minimum viable SMARTS)

Introduction

In current integration, H is the coordinator that will call SMARTS and KS. Now H starts a SMARTS instance by using a bash script.

From H’s perspective, in order to accelerate the integration, SMARTS needs to:

  1. reuse SUMO instance if the map is not changed.
  2. reset everything without restart SUMO when switching between scenarios ( Restart the SUMO process based on map change #73)

H’s Workflow should be:

  1. start the SMARTS service

    • service port
    • sumo port
    • number of SUMO external client
  2. reset/setup a scenario, need to specify:

    • scenario
    • ego agent
    • max_episode_steps
    • timestep
    • seed
    • ...
  3. start to run a scenario

  4. stop running the scenario

  5. Loop through from step 2 to 4 until service terminated

Per discussion, we will have a scenario service to provide functionalities such as initializing SMARTS, scenario setup and stepping, which is similar to what env layer is doing.

The Service should take care of:

  • creating SMARTS instance
  • setup scenario but not to run it until explicitly told to so do.
  • building the scenario if it has not been built
@liamchzh liamchzh mentioned this issue Jan 12, 2021
4 tasks
@liamchzh liamchzh added the bm label Jan 13, 2021
@liamchzh liamchzh added this to the 0.5 milestone Jan 13, 2021
@Gamenot
Copy link
Collaborator

Gamenot commented Jan 13, 2021

#76 Related ticket

@Gamenot Gamenot added ks and removed bm labels Jan 13, 2021
@Gamenot Gamenot changed the title Customized SMARTS service for KyberSim Customized SMARTS service for KS Jan 13, 2021
@Gamenot Gamenot changed the title Customized SMARTS service for KS Customized SMARTS service for MAD Jan 13, 2021
@Gamenot Gamenot changed the title Customized SMARTS service for MAD Customized SMARTS service for MAD co-sim Jan 13, 2021
@Gamenot Gamenot modified the milestones: 0.5, Backlog Jan 27, 2021
@Gamenot
Copy link
Collaborator

Gamenot commented Jun 16, 2021

On hold indefinitely.

@Gamenot Gamenot closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants