Add cce node pool resource #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilemusic
force-pushed
the
cce-node-pool
branch
from
604fd4b
to
f8c0956
Compare
ShiChangkuo
reviewed
Sep 4, 2020
Comment on lines
131
to
166
| "eip_ids": { | ||
| Type: schema.TypeSet, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Set: schema.HashString, | ||
| ConflictsWith: []string{ | ||
| "eip_id", "iptype", "bandwidth_charge_mode", "bandwidth_size", "sharetype", | ||
| }, | ||
| Deprecated: "use eip_id instead", | ||
| }, | ||
| "eip_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| ConflictsWith: []string{ | ||
| "eip_ids", "iptype", "bandwidth_charge_mode", "bandwidth_size", "sharetype", | ||
| }, | ||
| }, | ||
| "bandwidth_charge_mode": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| ConflictsWith: []string{"eip_ids", "eip_id"}, | ||
| }, | ||
| "iptype": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| RequiredWith: []string{ | ||
| "iptype", "bandwidth_size", "sharetype", | ||
| }, | ||
| }, | ||
| "sharetype": { | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
"eip_ids", "iptype", "bandwidth_charge_mode", "bandwidth_size" and "sharetype" are not necessary for now.
| "iptype", "bandwidth_size", "sharetype", | ||
| }, | ||
| }, | ||
| "billing_mode": { |
There was a problem hiding this comment.
the billing_mod can only be 0 for nodepool, so we can mark it as a computed attribute.
smilemusic
force-pushed
the
cce-node-pool
branch
2 times, most recently
from
bda8a36
to
ea9ba76
Compare
ShiChangkuo
reviewed
Sep 8, 2020
| public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDAjpC1hwiOCCmKEWxJ4qzTTsJbKzndLo1BCz5PcwtUnflmU+gHJtWMZKpuEGVi29h0A/+ydKek1O18k10Ff+4tyFjiHDQAT9+OfgWf7+b1yK+qDip3X1C0UPMbwHlTfSGWLGZquwhvEFx9k3h/M+VtMvwR1lJ9LUyTAImnNjWG7TAIPmui30HvM2UiFEmqkr4ijq45MyX2+fLIePLRIFuu1p4whjHAQYufqyno3BS48icQb4p6iVEZPo4AE2o9oIyQvj2mx4dk5Y8CgSETOZTYDOR3rU2fZTRDRgPJDH9FWvQjF5tA0p3d9CoWWd2s6GKKbfoUIi8R/Db1BSPJwkqB jrp-hp-pc" | ||
| } | ||
|
|
||
| resource "huaweicloud_cce_cluster_v3" "test" { |
There was a problem hiding this comment.
please use huaweicloud_cce_cluster instead of it.
ShiChangkuo
reviewed
Sep 8, 2020
website/docs/r/cce_node_pool.html.md
Outdated
| flavor_id = "s3.large.4" | ||
| availability_zone = var.availability_zone | ||
| key_pair = var.keypair | ||
| region = "cn-east-3" |
There was a problem hiding this comment.
region is not supported?
ShiChangkuo
reviewed
Sep 8, 2020
website/docs/r/cce_node_pool.html.md
Outdated
|
|
||
| * `os` - (Optional) Operating System of the node. Changing this parameter will create a new resource. | ||
| - For VM nodes, clusters of v1.13 and later support *EulerOS 2.5* and *CentOS 7.6*. | ||
| - For BMS nodes purchased in the yearly/monthly billing mode, only *EulerOS 2.3* is supported. |
There was a problem hiding this comment.
node pools only support VM nodes cluster, so the supported OS are EulerOS 2.5 and CentOS 7.6
smilemusic
force-pushed
the
cce-node-pool
branch
from
ac4f0aa
to
09c3a5a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testacc TEST=./huaweicloud/ TESTARGS='-run TestAccCCENodePool_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/ -v -run TestAccCCENodePool_basic -timeout 360m
=== RUN TestAccCCENodePool_basic
--- PASS: TestAccCCENodePool_basic (837.03s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 837.063s