Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No start_line/line in GHPullRequestReviewComment #1463

Closed
turbanoff opened this issue May 30, 2022 · 2 comments · Fixed by #1469
Closed

No start_line/line in GHPullRequestReviewComment #1463

turbanoff opened this issue May 30, 2022 · 2 comments · Fixed by #1469

Comments

@turbanoff
Copy link
Contributor

Describe the bug
https://docs.github.com/en/rest/pulls/comments#get-a-review-comment-for-a-pull-request
Github states that review comment has following fields:

 "start_line": {
        "type": [
          "integer",
          "null"
        ],
        "description": "The first line of the range for a multi-line comment.",
        "examples": [
          2
        ]
      },
      "original_start_line": {
        "type": [
          "integer",
          "null"
        ],
        "description": "The first line of the range for a multi-line comment.",
        "examples": [
          2
        ]
      },
      "start_side": {
        "type": [
          "string",
          "null"
        ],
        "description": "The side of the first line of the range for a multi-line comment.",
        "enum": [
          "LEFT",
          "RIGHT",
          null
        ],
        "default": "RIGHT"
      },
      "line": {
        "description": "The line of the blob to which the comment applies. The last line of the range for a multi-line comment",
        "type": "integer",
        "examples": [
          2
        ]
      },
      "original_line": {
        "description": "The line of the blob to which the comment applies. The last line of the range for a multi-line comment",
        "type": "integer",
        "examples": [
          2
        ]
      },

But there are no such fields in current API (class GHPullRequestReviewComment)

Expected behavior
GHPullRequestReviewComment contains all fields which are provided by GitHub

Additional context
Thank you for wonderful library! ❤️

@kisaga
Copy link
Contributor

kisaga commented Jun 1, 2022

May I pick this issue ? Since it is my first actual contribution to OSS it may take some time

@bitwiseman
Copy link
Member

Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants