Add support for handling team's privacy

[basejumpa]

Please add ability to get or set a team's property privacy (see https://developer.github.com/v3/teams/#parameters). Current version 1.94.

Usecases

• Set visibility when creating a team or teams
• Set visibility of existing team or teams
• Get visibility of a team or teams

Affected API elements (list may not exchaustive):

• Class GHTeam
• Class GHOrganization
• Methods createTeam (2x)

(Dirty) workaround

This is my workaround using in my groovy scripts currently:

// File kohsuke_github_workarounds.groovy
// Use it with import kohsuke_github_workarounds

@Grab(group='org.kohsuke', module='github-api', version='1.94')
import org.kohsuke.github.*

// Works around https://github.com/kohsuke/github-api/issues/455
static void setPrivacy (String token, GHTeam team, String privacy) {
   allowMethods('PATCH')
   def jsonString = "{ \"name\": \"${team.getName()}\", \"privacy\": \"$privacy\" }"
   def con = "https://api.github.com/teams/${team.getId()}".toURL().openConnection()
   con.setDoOutput(true)
   con.setDoInput(true)
   con.setRequestMethod("PATCH");
   con.setRequestProperty("Authorization", "token $token")
   con.setRequestProperty("Content-Type", "application/json")
   con.connect()
   con.outputStream.withWriter { writer ->
     writer << jsonString
   }
   String response = con.inputStream.withReader { Reader reader -> reader.text }
}

import java.io.IOException;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
import java.net.HttpURLConnection;
import java.net.URL;
import java.util.Arrays;
import java.util.LinkedHashSet;
import java.util.Set;

private static void allowMethods(String... methods) {
    try {
        Field methodsField = HttpURLConnection.class.getDeclaredField("methods");

        Field modifiersField = Field.class.getDeclaredField("modifiers");
        modifiersField.setAccessible(true);
        modifiersField.setInt(methodsField, methodsField.getModifiers() & ~Modifier.FINAL);

        methodsField.setAccessible(true);

        String[] oldMethods = (String[]) methodsField.get(null);
        Set<String> methodsSet = new LinkedHashSet<>(Arrays.asList(oldMethods));
        methodsSet.addAll(Arrays.asList(methods));
        String[] newMethods = methodsSet.toArray(new String[0]);

        methodsField.set(null/*static field*/, newMethods);
    } catch (NoSuchFieldException | IllegalAccessException e) {
        throw new IllegalStateException(e);
    }
}

[apratina]

It would be good to have support for this :)

[timja]

This + more is covered in: #683