Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubborn connect_async #12

Merged
merged 1 commit into from Dec 27, 2021
Merged

stubborn connect_async #12

merged 1 commit into from Dec 27, 2021

Conversation

boymaas
Copy link
Contributor

@boymaas boymaas commented Dec 27, 2021

While testing I noticed a stalling due to the connect_async hanging in the underlying tungstenite. src/stubborn implements a timeout and retry mechanism to ensure active reconnecting.

Copy link
Contributor

@karim-agha karim-agha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boymaas boymaas merged commit 700c79a into master Dec 27, 2021
@boymaas boymaas deleted the feature/stubborn-async-connect branch December 27, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants