New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use base64+zstd for account data encoding by default, add ping support and make recv cancellation safe #18
Conversation
@dovahcrow let us know when it’s ready |
It's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a very thorough review on my part, but lgtm on first sight. Maybe it's good to have one more pair of eyes looking at it.
Looks good, a keep alive and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo.toml
Outdated
license = "Apache-2.0" | ||
name = "solana-shadow" | ||
repository = "https://github.com/hubble-markets/solana-shadow" | ||
version = "0.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please bump the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Sorry I squeezed the fixes for #17 #19 and a base64+zstd fix into the same PR.
The first commit in the PR fixes the following problem.
The jsonParsed encoding won't work if the account data can be parsed by the RPC node. For example, the spl-token account will be actually parsed! The notification from WS becomes
and cannot be deserialized into the AccountRepresentation struct.
Choosing base64+zstd because it is compressed and should save network bandwidth theoretically (which is the bottleneck).
The rest two commits fixes #17 and #19.