Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Refactoring Component TheFooterMobile.vue #31

Closed
Zermoran opened this issue Nov 17, 2020 · 0 comments · Fixed by #32
Closed

[FEATURE] Refactoring Component TheFooterMobile.vue #31

Zermoran opened this issue Nov 17, 2020 · 0 comments · Fixed by #32
Labels
enhancement New feature or request

Comments

@Zermoran
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display images via img-lazy tag which should have width and height attributes when possible and import components dynamically.

Describe the solution you'd like
Changing all occurrences of img to img-lazy. Changing import of the Newsletter component to dynamic import.
@Zermoran Zermoran added the enhancement New feature or request label Nov 17, 2020
@Zermoran Zermoran linked a pull request Nov 17, 2020 that will close this issue
issue#31 changed img to img-lazy, changed component to dynamic import #32
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Zermoran