Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Delivery per Pull Request on Heroku #183

Closed
discorick opened this issue Jan 29, 2016 · 4 comments
Closed

Continuous Delivery per Pull Request on Heroku #183

discorick opened this issue Jan 29, 2016 · 4 comments

Comments

@discorick
Copy link
Member

https://devcenter.heroku.com/articles/github-integration-review-apps

@dahlbyk dahlbyk changed the title CD on Heroku Continuous Delivery per Pull Request on Heroku Jan 29, 2016
@dahlbyk
Copy link
Member

dahlbyk commented Feb 9, 2016

So I got Heroku review apps set up on #201....and GitHub OAuth rejects auth because the URL doesn't match. This is...unfortunate.
firefox_2016-02-09_01-11-38

@dahlbyk
Copy link
Member

dahlbyk commented Feb 9, 2016

I mentioned this challenge to @Steven-Pingel and he directed me toward http://stackoverflow.com/a/32544022/54249. We should be able to use HEROKU_APP_NAME and HEROKU_PARENT_APP_NAME to effectively direct per-PR authorizations through the parent app.

@dahlbyk
Copy link
Member

dahlbyk commented Feb 10, 2016

Looks like we're going to have to replace Warden::GitHub::Config.normalized_uri(), which is hard-coded to build redirect_uri from request.url.

@dahlbyk
Copy link
Member

dahlbyk commented Mar 3, 2016

Now that the relevant code has been shipped, review apps can be deployed from https://dashboard.heroku.com/apps/huboard-rails/deploy/github. PRs without the new app.json (and relevant Warden code) won't work, so we'll want to pull master into any open branches that we want to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants