Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The query is optional, but if it's present, whitespace is required between help and the query #8

Merged
merged 1 commit into from Oct 9, 2015

Conversation

alindeman
Copy link
Contributor

@alindeman
Copy link
Contributor Author

I've run this against a hubot locally and it does what's expected for both !help and !help <filter>

@therealklanni
Copy link
Contributor

Looks good to me. I wish we had unit tests on more scripts to catch stuff like that. Good thing you caught it though.

I'm OK to merge this, but I'll wait and see if @technicalpickles or @michaelansel have any input first. I'll try to remember to merge by tomorrow if there's no response from these guys, and hopefully one of them can publish it after.

therealklanni added a commit that referenced this pull request Oct 9, 2015
The query is optional, but if it's present, whitespace is required between help and the query
@therealklanni therealklanni merged commit 8cbb79f into hubotio:master Oct 9, 2015
@therealklanni
Copy link
Contributor

@technicalpickles @michaelansel publish please?

@alindeman
Copy link
Contributor Author

@technicalpickles @michaelansel Do you pushing a new version of this package, or delegating the task to someone else?

@alindeman alindeman deleted the hubot-help-spacing branch October 14, 2015 12:25
@alindeman alindeman restored the hubot-help-spacing branch October 14, 2015 12:25
@technicalpickles
Copy link
Member

@alindeman gently nudged me on twitter about getting this released, so I added him as an owner of the npm package ✨

@alindeman
Copy link
Contributor Author

👍 0.1.2 has been published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants