Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coffeescript #1694

Merged
merged 1 commit into from Nov 11, 2023
Merged

Remove Coffeescript #1694

merged 1 commit into from Nov 11, 2023

Conversation

joeyguerra
Copy link
Member

BREAKING CHANGES: Removed CoffeeScript support; .coffee files will no longer load
BREAKING CHANGES: Removed es2015.js file; import index.js file instead

… longer load

BREAKING CHANGES: Removed es2015.js file; import index.js file instead
Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done! Keep up good work!

@joeyguerra joeyguerra merged commit f11e5af into main Nov 11, 2023
6 checks passed
@joeyguerra joeyguerra deleted the remove-coffeescript branch November 11, 2023 22:40
Copy link

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

joeyguerra added a commit that referenced this pull request Nov 12, 2023
…ion.

Revert "BREAKING CHANGES: Removed CoffeeScript support; .coffee files will no longer load (#1694)"

This reverts commit f11e5af.
joeyguerra added a commit that referenced this pull request Nov 12, 2023
fix: Accidently releasing the removal of CoffeeScript in a minor version.
fix: --help and the Windows test for it.

Revert "BREAKING CHANGES: Removed CoffeeScript support; .coffee files will no longer load (#1694)"
This reverts commit f11e5af.
@stahnma
Copy link

stahnma commented Nov 16, 2023

Why remove this and break lots of plugins in the ecosystem? I don't see this tied to an issue with discussion or anything like that.

@joeyguerra
Copy link
Member Author

A few thoughts:

Version 10.0.5 still supports coffeescript. For those still using hubot and coffeescripts, they should set the hubot peer dependency to version 10.

I haven’t seen any GitHub issues about breaking plugins. I’d love to know how many people are still using hubot. And hubot with coffeescripts.

Removing coffeescript was on the roadmap issue #1658

Some background:
Development on hubot stalled sometime around 2017. I asked to be a maintainer and was added to the repo this year (at least I think it was this year). My objective was to modernize the code base, and try to pick up where the other maintainers left off with the goals in the evolution repo.

in my research, I found that almost every repo I found was last updated many years ago. Leaving me with the impression that the hubot ecosystem has gone stale.

Being the 1 person maintaining it, I’ve been trying to reduce the maintenance surface area. Specifically reducing dependencies. I still get dependabot notifications for the yo generator repo. Gotta figure out what to do with that.

I think there’s better adoption for ES6, which is my motivation to modernize hubot and evolve it to a new vision having been left stale for so long.

With all those points in mind, I removed coffeescript in v11 as I try to incorporate some of the goals initially defined in the evolution repo and figure out where hubot now fits in todays universe.

Are you still using hubot? With coffeescripts? I’d love to hear your story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants