Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response.reply is not a function in CatchAll listener #1721

Closed
joeyguerra opened this issue Apr 5, 2024 · 4 comments · Fixed by #1720
Closed

response.reply is not a function in CatchAll listener #1721

joeyguerra opened this issue Apr 5, 2024 · 4 comments · Fixed by #1720
Labels

Comments

@joeyguerra
Copy link
Member

Someone submitted PR #1718. After no response about a test, I wrote a failing test to highlight the scenario.

Copy link

github-actions bot commented Apr 5, 2024

🎉 This issue has been resolved in version 11.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PColuccio
Copy link

@joeyguerra Thanks for getting the fix in! I was hoping to get a test written this weekend.

@joeyguerra
Copy link
Member Author

You're welcome. A test would still be great. The more perspectives I can get on this, the better.

@joeyguerra
Copy link
Member Author

By the way, I believe this

const result = await this.receive(new Message.CatchAllMessage(context.response.message))
is the start of the call stack that results in calling catch all listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants