-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling with arrow-keys is not working #71
Comments
@bryan-foong Can you provide an example, or an animated GIF? I have no such problem when I run the examples locally with |
Ok I found out that this only happens on the Async list but not static list. Check the demo that is showing "Contributors (Async)" and "Github users (Async with fetch.js)", so does "Cities (Large Dataset)". |
Ok the latest patch seems to work now. Thanks @TrevorBurnham |
Guys, this bug is back on 1.0.0-rc.10.patch1, can we please re-open this issue? |
@husek I'm only able to replicate at http://github.hubspot.com/react-select-plus/ with the Cities examples (the one that uses react-virtualized-select). The other examples seem to handle the arrow keys as expected: Can you give me more details on the problems you're experiencing with those non-virtualized examples? |
hey @TrevorBurnham, And yes you can't replicate at that link indeed, but it seems that this example is running 1.0.3-rc3.patch3. I've tried to run the examples on localhost using the latest version (1.0.0-rc.10.patch1) and sure enough, I was able to replicate |
I'm still unable to replicate in the Contributors or Github users examples when running the latest I do notice that scrolling with the arrow keys doesn't work when two options have the same |
Thanks for the answer @TrevorBurnham, but I'm afraid this isn't the case. Here's two gists for you: I cloned the master branch, removed pretty much everything from the /examples/src/app.js, leaving it like this: import Example from './components/Example';
and ta-da bug replicated! |
hey @TrevorBurnham, were you able to replicate that after my last post? |
i have updated to 1.0.0-rc.3.patch5, have noticed that the scrolling key is not working but it works on the demo page of react-select-plus.
The text was updated successfully, but these errors were encountered: