Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting is not working #20

Closed
Erfahrungen opened this issue Mar 1, 2015 · 4 comments
Closed

Sorting is not working #20

Erfahrungen opened this issue Mar 1, 2015 · 4 comments

Comments

@Erfahrungen
Copy link

Hi there,

I really like your lightweight table sorter. But I've just realized it's not working, also in the demo on your website here: http://github.hubspot.com/sortable/

If you sort descending by "Usage" the Opera entry with 1.03% is listed before Other with 2.44%.

Can you fix that?

Thanks a lot

@theKirt
Copy link

theKirt commented Jul 7, 2015

Hi,

Not sure if you figured it out but the td in question has the attribute data-value="0" added to it.

I think this may have been put in as an example of using the data-value attribute to change how the data is sorted.... then again it could just be human error ;)

@adamschwartz
Copy link
Contributor

@kirtamus you are correct. Thanks for filling in here.

@timmfin please close this as well.

@timmfin timmfin closed this as completed Sep 13, 2015
@adamschwartz
Copy link
Contributor

Thanks again :)

@theKirt
Copy link

theKirt commented Sep 14, 2015

no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants