Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a contact fails with "undefined method 'with_indifferent_access' for nil:NilClass (NoMethodError)" #193

Closed
kitebuggy opened this issue May 2, 2019 · 1 comment

Comments

@kitebuggy
Copy link

This HubSpot API contact update endpoint does not respond with the updated contact, just with a response code.

Trying to save a changed contact record will therefore fail here when trying to parse the nil body response.

@cbisnett
Copy link
Collaborator

cbisnett commented May 4, 2019

This is something I ran into when I was implementing update for both instances of Resource and for the class level method. The API endpoints aren't consistent. I found some endpoints that will return only a success code, some that will return all the properties of the updated resource, and others that will return only the updated properties.

I've been thinking about the best path forward and I think one of the goals of the library is to provide an interface to the APIs that is consistent even if the API endpoints are not. So I'm thinking the lowest common denominator is likely what will have to be used here and assume that all endpoints only return a success code. From there we can merge in the changed properties. If the user wants the full property details including the updated history and other metadata associated with the property then they'll have to call reload.

I hadn't realized this would also be broken with save and there aren't enough tests to cover all the new functionality yet so thank you for submitting a ticket. I'll take a look at this and will likely fix this as part of handling updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants