check that weights don't depend on output_type_id
in settings where that would not lead to a valid ensemble
#35
Labels
output_type_id
in settings where that would not lead to a valid ensemble
#35
Mainly, I think this is a check we need when the output type is pmf or cdf. In that case, allowing the weights to depend on the output_type_id could lead to an invalid predictive distribution. We could implement this check in
hubEnsembles::simple_ensemble
, and I think that would be good enough sincehubEnsembles::linear_pool
callssimple_ensemble
.I initially thought that we should also not allow weights to depend on the sample index if the output type is sample, but I don't think there's necessarily anything wrong with a per-sample weighting, e.g. if the hub or modeler has some extra information about how the different samples are generated and wants to weight them based on that that factor.
The text was updated successfully, but these errors were encountered: