Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more generic default params argument in get_task_id_params #13

Closed
elray1 opened this issue Oct 4, 2022 · 0 comments · Fixed by #15
Closed

more generic default params argument in get_task_id_params #13

elray1 opened this issue Oct 4, 2022 · 0 comments · Fixed by #15

Comments

@elray1
Copy link

elray1 commented Oct 4, 2022

Currently, the default value of the params argument to get_task_id_params is c("location", "horizon", "origin_date"), but those specific model task id variables are not relevant to all hubs. It may make sense for this function to be a method on a hub_connection object, and for it to do something like default to returning the first task id variable in the hub metadata file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant