Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix direct SmartThreadPool dependency #16

Closed
robhruska opened this issue Jun 16, 2014 · 3 comments
Closed

Fix direct SmartThreadPool dependency #16

robhruska opened this issue Jun 16, 2014 · 3 comments
Labels
enhancement

Comments

@robhruska
Copy link
Member

The Problem

Mjolnir currently depends on changes in robhruska/SmartThreadPool, which is forked from amibar/SmartThreadPool. A PR has been submitted to the upstream, but hasn't yet been accepted and pushed to the SmartThreadPool nuget.org package.

The Workaround

SmartThreadPool.dll is delivered statically with Mjolnir, which references it directly (instead of via a NuGet package reference).

Possible Solutions

  • (Ideal) Work with the maintainers of amibar/SmartThreadPool to help get the PR accepted and a new version published to NuGet.
  • (Less Ideal) Create a nuget.org package for the forked version and depend on it from Mjolnir.
  • (Probably not feasible in the short term) Use a different thread pool library.
@robhruska robhruska mentioned this issue Sep 29, 2014
Closed
@robhruska
Copy link
Member Author

Addressed in #47 (Version 2.6.0), but the dependency has not yet been fully removed. That will likely happen in a future major release.

@robhruska robhruska mentioned this issue Apr 3, 2017
Merged
@robhruska
Copy link
Member Author

Removed in #60

@robhruska
Copy link
Member Author

#60 has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robhruska