New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread Modeling - ML Approach #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the PR. Filters and models (TAR, RNN, MLP, PiSigma) look good. Will have to check the roller classes.
Waiting for the Notebook to check how the created structures work and if we should change anything in terms of input/output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great draft PR! Roller classes look good.
Waiting for the final code adjustments and docs to do a more detailed review.
… for futures rolling class and also added the SpreadModelingHelper Class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code part of this PR. There are places to fix, as some docstrings are lacking descriptions. Overall, the code itself is approved.
Please check every place where the functionality was later changed, but the variables are still present in the docstrings. (If the functions work as you expect them to)
Fixed some small details here and there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are great, a lot of work here. Awesome Futures Rollover section 👍
Please finish the code examples and add references for the images where needed. This is important! Otherwise, the docs are approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests look good 👌
I see some sections are yet to be finished. Will check them again once the coverage is passing for this PR.
…s/arbitragelab into spread_modeling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finishing the docs and the unit tests. This PR is almost complete now. 🙂
We should add links to the notebooks in the docs, and I think the unit tests need improvement. Will discuss in more detail over the call.
Purpose
Implementation of the second element of the ML Roadmap - Spread modelling. Implementation of the concepts for the paper "Modelling and trading the gasoline crack spread: A non-linear story" by Christian L. Dunis, Jason Laws and Ben Evans.
Approach
Applying ML to model pair spreads.
Tests for New Behavior
The following unit tests were added:
Checklist
Make sure you did the following (if applicable):
./pylint
to make sure code style is consistent.Learning [to be updated]
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem