Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arblab tearsheet #49

Merged
merged 32 commits into from Jun 9, 2021
Merged

Arblab tearsheet #49

merged 32 commits into from Jun 9, 2021

Conversation

vlrie
Copy link

@vlrie vlrie commented Apr 21, 2021

Purpose

Creating the module that provides illustrative tear sheets for different modules of Arbitragelab

Tests for New Behavior

Unit tests pending

Checklist

Make sure you did the following (if applicable):

  • Added tests for any new features or behaviors.
  • Ran ./pylint to make sure code style is consistent.
  • Built and reviewed the docs.
  • Added a note to the changelog.

Learning

https://plotly.com/dash/

@vlrie vlrie requested a review from PanPip April 21, 2021 17:09
@vlrie vlrie self-assigned this Apr 21, 2021
@PanPip PanPip added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 28, 2021
Copy link
Contributor

@PanPip PanPip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

The module and the docs are good. I've adjusted the unit tests and did minor fixes to the docs. After ACF/PACF changes it's ready to be merged!

Copy link
Contributor

@PanPip PanPip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vlrie, this PR is now complete 🙌

Ready to be merged.

@PanPip
Copy link
Contributor

PanPip commented Jun 9, 2021

Renamed docs folder.

Merging PR now.

@PanPip PanPip merged commit 9efc4d3 into develop Jun 9, 2021
@PanPip PanPip deleted the arblab_tearsheet branch June 30, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants