Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve entropy.py functions #414

Open
PanPip opened this issue Jun 30, 2020 · 5 comments
Open

Further improve entropy.py functions #414

PanPip opened this issue Jun 30, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PanPip
Copy link
Contributor

PanPip commented Jun 30, 2020

According to @rspadim, functions in entropy.py could use numpy array instead of strings, as it's better to numba.

Guide on how to implement this is available in the comments in PR #311 .

@PanPip PanPip added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2020
@rspadim
Copy link

rspadim commented Jun 30, 2020

@kenluck2001
Copy link

Can I use this ticket as a first-time issue to fix the issue and understand the codebase?

@Jackal08
Copy link
Member

@kenluck2001, I think so. It's from a very long time ago but I don't think we made changes.

@kenluck2001
Copy link

Hi @Jackal08, I have started to work on it.
Is this the required file: mlfinlab/mlfinlab/microstructural_features/entropy.py ?
Looking forward to confirm the exact location of the file.

@Dhavin
Copy link

Dhavin commented Aug 22, 2021

Hello @Jackal08, I would like to contribute to this project by solving this issue. Can I? If @kenluck2001 has not yet been solved already?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants