Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed calls for validCallback/invalidCallback #206

Merged
merged 3 commits into from
May 12, 2016

Conversation

dmitry-dedukhin
Copy link
Contributor

This fixes #189

@hueitan
Copy link
Owner

hueitan commented May 11, 2016

Thanks for the quick fix.

Also, use the grunt build to generate the related files.

@dmitry-dedukhin
Copy link
Contributor Author

Hmm, I think tests should be updated too.

@hueitan
Copy link
Owner

hueitan commented May 11, 2016

Yes, that will be very nice, double thumb 👍 👍

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 93.22% when pulling 6c4700d on dmitry-dedukhin:patch-2 into 30a00bd on huei90:master.

@dmitry-dedukhin
Copy link
Contributor Author

dmitry-dedukhin commented May 11, 2016

@huei90 I've added tests and run build.
But I had to do some additional changes to make jshint happy.
Additionally, grunt build has changed some indents.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage decreased (-0.02%) to 93.197% when pulling 4679067 on dmitry-dedukhin:patch-2 into 30a00bd on huei90:master.

//var angular = require('./node_modules/angular/angular.js');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happen to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jshint shows an error:

      1 |var angular = require('./node_modules/angular/angular.js');
             ^ Redefinition of 'angular'.

I don't know what is a purpose of this line...

@dmitry-dedukhin
Copy link
Contributor Author

dmitry-dedukhin commented May 12, 2016

@huei90 what do you think about build problems?
Should I try to fix them?

@hueitan
Copy link
Owner

hueitan commented May 12, 2016

Yes @dmitry-dedukhin the build process is broken. Looks like the before commit doesn't care the build.

@hueitan
Copy link
Owner

hueitan commented May 12, 2016

I would suggest move bundle.js and main.js to the root as these are not the real src
and make the jshint ignore them.

@dmitry-dedukhin
Copy link
Contributor Author

What about blank lines deletion and some other automatic code changes?
Looks like this is performed by jsbeautifier task.

@hueitan
Copy link
Owner

hueitan commented May 12, 2016

The task performed by jsbeautifier is approved!

@dmitry-dedukhin
Copy link
Contributor Author

dmitry-dedukhin commented May 12, 2016

But it has deleted blank lines from src/module.js and you have mentioned this.
May be deleting pattern '*.js' from jsbeautifier config will be a good idea taking into account that we move bundle.js and main.js to the root?

@hueitan
Copy link
Owner

hueitan commented May 12, 2016

Initial yes, but I was look the code and found the weird blank lines, we should remove them.

@dmitry-dedukhin
Copy link
Contributor Author

@huei90 I've just commited build fixes, please take a look.

@hueitan
Copy link
Owner

hueitan commented May 12, 2016

Looks good now, merge after the test.

@coveralls
Copy link

coveralls commented May 12, 2016

Coverage Status

Coverage decreased (-0.02%) to 93.197% when pulling c502641 on dmitry-dedukhin:patch-2 into 30a00bd on huei90:master.

@hueitan hueitan merged commit 68e3ef9 into hueitan:master May 12, 2016
@hueitan
Copy link
Owner

hueitan commented May 12, 2016

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valid-callback & invalid-callback not working on angular-validation 1.4
3 participants