-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed calls for validCallback/invalidCallback #206
Conversation
Thanks for the quick fix. Also, use the |
Hmm, I think tests should be updated too. |
Yes, that will be very nice, double thumb 👍 👍 |
@huei90 I've added tests and run build. |
//var angular = require('./node_modules/angular/angular.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jshint shows an error:
1 |var angular = require('./node_modules/angular/angular.js');
^ Redefinition of 'angular'.
I don't know what is a purpose of this line...
@huei90 what do you think about build problems? |
Yes @dmitry-dedukhin the build process is broken. Looks like the before commit doesn't care the build. |
I would suggest move bundle.js and main.js to the root as these are not the real |
What about blank lines deletion and some other automatic code changes? |
The task performed by jsbeautifier is approved! |
But it has deleted blank lines from src/module.js and you have mentioned this. |
Initial yes, but I was look the code and found the weird blank lines, we should remove them. |
@huei90 I've just commited build fixes, please take a look. |
Looks good now, merge after the test. |
🍻 |
This fixes #189