Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s.src = 'http://xxx.com/sdk.js'; Is a valid domain, please change it #15

Closed
adamellsworth opened this issue Aug 4, 2017 · 2 comments
Closed

s.src = 'http://xxx.com/sdk.js'; Is a valid domain, please change it #15

adamellsworth opened this issue Aug 4, 2017 · 2 comments

Comments

@adamellsworth
Copy link
Contributor

I forgot to change the URL when I copied one of the examples and mistakenly made valid requests to xxx.com/sdk.js over my company's network.

To prevent others from making the same mistake and potentially getting fired or reprimanded, it would be wise to change it to something like https://<YOUR DOMAIN>.com/sdk.js
@hueitan
Copy link
Owner

hueitan commented Aug 4, 2017

👍 Thanks! Your suggestion is valid and true, let's change to the URL you suggest! Do you mind sending pull request to update it?

@adamellsworth
Copy link
Contributor Author

#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hueitan @adamellsworth