Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation #3

Closed
KyleKun opened this issue Jul 16, 2020 · 10 comments · Fixed by #4
Closed

Add animation #3

KyleKun opened this issue Jul 16, 2020 · 10 comments · Fixed by #4
Assignees
Labels
enhancement New feature or request

Comments

@KyleKun
Copy link

KyleKun commented Jul 16, 2020

Hello! This package is great, thanks for the hard work!

Would it be possible to add an animation when going to the next step?

A really simple thing, just filling the color slowly until the next step to show more clearly to users that they advanced to the next step.

Thanks in advance!

@KyleKun KyleKun added the enhancement New feature or request label Jul 16, 2020
@huextrat
Copy link
Owner

Hi!

Yes it's something I wanted for this package but due to lack of time it hasn't been done yet.
I'm open to the proposal if anyone wants to do it ;)

I'll work on it in the coming weeks but there's a lot of refacto to do I think to add a nice animation.

@KyleKun
Copy link
Author

KyleKun commented Jul 16, 2020

Thanks for the quick response! Looking forward to it 😀

@huextrat huextrat linked a pull request Jul 16, 2020 that will close this issue
@huextrat
Copy link
Owner

Hey @KyleKun, I've initiated a big part of the feature on ongoing PR #4
If you have some time to try it and send some feedback, will be great thanks ;)

@KyleKun
Copy link
Author

KyleKun commented Jul 17, 2020

Hey @huextrat, first of all, thanks again for the quick update!

Just tested it and the line's animation is perfect!

But if I use the step's animation together, this is what it looks like when going to the previous step: gif

@KyleKun
Copy link
Author

KyleKun commented Jul 17, 2020

In fact, it wouldn't be a problem using the same color for the lines and step, but it would be nice if the animation didn't conflict with the line's color if they are different

@huextrat
Copy link
Owner

Thanks for the feedback. Indeed I had seen for the problem of the step animation when going to the previous step. I will improve it to have something better ;)

@huextrat
Copy link
Owner

@KyleKun Hey !

I've updated the animation for the steps that seem much better to me personally, what do you think?

@KyleKun
Copy link
Author

KyleKun commented Jul 18, 2020

@huextrat Much better!!

Just a small detail, is there a way to prevent the layout to adjust itself when the animation occurs? I think the step animation resizing affects the height of the container and it "bounces", but I am not sure if this would be better to be dealt by my code or by the lib, take a look: gif

@huextrat
Copy link
Owner

Yes sure I'll do it soon and then release 1.1.0 😉

@KyleKun
Copy link
Author

KyleKun commented Jul 18, 2020

Yay, thank you again! 😀😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants