Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support ujson if installed #577

Merged
merged 6 commits into from Oct 30, 2017

Conversation

danigosa
Copy link

If installed but no wish to use it set HUG_USE_UJSON=0 environmental variable. This is for the sake of people not wanting to use ujson even when installed in the python environment.

This would increase the performance dramatically for those microservices that are basically JSON loaders/dumpers endpoints.

- If installed but no wish to use it set HUG_USE_UJSON=0 environmental variable
@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Coverage decreased (-0.04%) to 99.806% when pulling 366a15a on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

Dani Gonzalez added 2 commits October 24, 2017 08:13
- Mimic json built-in behavior by settings `escape_forward_slashes=False`
@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.3%) to 99.535% when pulling 73c2307 on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.3%) to 99.535% when pulling f78b5e1 on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

@danigosa
Copy link
Author

@timothycrosley using it in our internal projects successfully

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.3%) to 99.496% when pulling da1785d on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage decreased (-0.4%) to 99.458% when pulling d995da4 on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage decreased (-0.4%) to 99.458% when pulling d995da4 on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage increased (+0.0001%) to 99.844% when pulling b26c952 on danigosa:feature/ujson_support into aec8a6f on timothycrosley:develop.

@timothycrosley
Copy link
Collaborator

Looks good, thanks!

@timothycrosley timothycrosley merged commit 367b50b into hugapi:develop Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants