-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUID parameter type #126
Add UUID parameter type #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 95.48% 95.54% +0.06%
==========================================
Files 4 4
Lines 443 449 +6
Branches 94 95 +1
==========================================
+ Hits 423 429 +6
Misses 6 6
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for your contribution.
The current problem is that I don't think OAPIUUID()
is a good field name because it's naming rule is not consistent with other fields and also not intuition. I have give some feedback, please check it.
0aa08f4
to
c821c47
Compare
Co-Authored-By: Jacob <chenjr0719@gmail.com>
c821c47
to
df98f95
Compare
@chenjr0719 Thanks for the review! I've made the changes you suggested. How is it looking now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clarkenciel Looks great.
Fixes #125