Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID parameter type #126

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

clarkenciel
Copy link
Contributor

Fixes #125

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #126 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   95.48%   95.54%   +0.06%     
==========================================
  Files           4        4              
  Lines         443      449       +6     
  Branches       94       95       +1     
==========================================
+ Hits          423      429       +6     
  Misses          6        6              
  Partials       14       14
Impacted Files Coverage Δ
sanic_openapi/doc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99b98f...df98f95. Read the comment docs.

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thanks for your contribution.

The current problem is that I don't think OAPIUUID() is a good field name because it's naming rule is not consistent with other fields and also not intuition. I have give some feedback, please check it.

sanic_openapi/doc.py Outdated Show resolved Hide resolved
sanic_openapi/doc.py Outdated Show resolved Hide resolved
sanic_openapi/doc.py Outdated Show resolved Hide resolved
tests/test_fields.py Outdated Show resolved Hide resolved
Co-Authored-By: Jacob <chenjr0719@gmail.com>
@clarkenciel
Copy link
Contributor Author

@chenjr0719 Thanks for the review! I've made the changes you suggested. How is it looking now?

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkenciel Looks great.

@chenjr0719 chenjr0719 merged commit 9dd6c1a into sanic-org:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] UUIDs aren't handled properly
3 participants