Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ASGI compatibility through server event #130

Merged
merged 2 commits into from Aug 21, 2019

Conversation

tng10
Copy link
Contributor

@tng10 tng10 commented Aug 8, 2019

Change server event (listener)

from
@swagger_blueprint.listener("before_server_start")
to
@swagger_blueprint.listener("after_server_start")

More details at
https://sanic.readthedocs.io/en/latest/sanic/deploying.html#running-via-asgi

Change server event (listener) from `@swagger_blueprint.listener("before_server_start")` to `@swagger_blueprint.listener("after_server_start")`

More details at
https://sanic.readthedocs.io/en/latest/sanic/deploying.html#running-via-asgi
@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files           4        4           
  Lines         449      449           
  Branches       95       95           
=======================================
  Hits          429      429           
  Misses          6        6           
  Partials       14       14
Impacted Files Coverage Δ
sanic_openapi/swagger.py 95.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c334d2...f347971. Read the comment docs.

@chenjr0719 chenjr0719 merged commit a6df84d into sanic-org:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants