Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typing.Sequence and typing.List #136

Merged
merged 5 commits into from Oct 23, 2019

Conversation

viniciusd
Copy link
Contributor

Incrementally address #128.

#129 provides basic support to type hinting. With this pull request, support to typing.Sequence and typing.List is added.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #136 into master will decrease coverage by 0.41%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   95.56%   95.15%   -0.42%     
==========================================
  Files           4        4              
  Lines         451      454       +3     
  Branches       95       96       +1     
==========================================
+ Hits          431      432       +1     
- Misses          6        7       +1     
- Partials       14       15       +1
Impacted Files Coverage Δ
sanic_openapi/doc.py 99.08% <33.33%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360a033...5d57ff2. Read the comment docs.

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjr0719 chenjr0719 merged commit f80d19c into sanic-org:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants