Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: deprecate the use of remove_route #1568

Merged
merged 2 commits into from May 10, 2019

Conversation

yunstanford
Copy link
Member

#1511 for 19.06

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1568 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
+ Coverage   91.35%   91.35%   +<.01%     
==========================================
  Files          18       18              
  Lines        1827     1828       +1     
  Branches      351      351              
==========================================
+ Hits         1669     1670       +1     
  Misses        132      132              
  Partials       26       26
Impacted Files Coverage Δ
sanic/app.py 92.48% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669cfa3...bd89c7f. Read the comment docs.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunstanford yunstanford merged commit 25e2151 into master May 10, 2019
@ahopkins ahopkins deleted the deprecate-route-removal branch May 11, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants