Update README re: experimental support for Windows #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in sanic-org#1517 , Windows support is "experimental" and does not currently support multiple workers.
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 23 23
Lines 2276 2276
Branches 426 426
=======================================
Hits 2093 2093
Misses 142 142
Partials 41 41Continue to review full report at Codecov.
|
ahopkins
approved these changes
Feb 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1517 , Windows support is "experimental" and does not currently support multiple workers. I think it would be very useful to mention this in the main README under the installation section as supported by @sjsadowski here.