Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Time Range Argument to Simphony Call #50

Closed
1 of 2 tasks
ZackAttack614 opened this issue Feb 8, 2019 · 1 comment
Closed
1 of 2 tasks

Add Time Range Argument to Simphony Call #50

ZackAttack614 opened this issue Feb 8, 2019 · 1 comment
Assignees
@ZackAttack614
Labels
enhancement New feature or request

Comments

@ZackAttack614
Copy link
Contributor

ZackAttack614 commented Feb 8, 2019 •
edited
Loading

There should be a new argument to simphony called timeRange, which is a vector of two values. The first is the minimum time to be sampled, and the second is the maximum time to be sampled.

  • If timepointsType is 'auto', the timeRange argument should not be used.
  • The minimum time specified should be the true minimum time for samples created. The maximum time may not be included in the sample time points if the specified interval does not sum to the provided max.
@ZackAttack614 ZackAttack614 added the enhancement New feature or request label Feb 8, 2019
@ZackAttack614 ZackAttack614 self-assigned this Feb 8, 2019
@ZackAttack614
Copy link
Contributor Author

@jakejh I've written it such that timeRange is always used, even if timepointsType = 'auto' - it defaults to c(0, period), whatever period is. Do you think that will work?

@jakejh jakejh closed this as completed in f549fcc Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZackAttack614 ZackAttack614

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZackAttack614