Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkcon] ignores blocked flag on packages #71

Open
eworm-de opened this issue Jul 20, 2015 · 5 comments
Open

[pkcon] ignores blocked flag on packages #71

eworm-de opened this issue Jul 20, 2015 · 5 comments

Comments

@eworm-de
Copy link
Collaborator

For testing purpose I added sudo to to IgnorePkg in pacman.conf (so backend in alpm, but I do not think this matters).

Getting the update status works, updates are listed, sudo is marked blocked:

root@08-00-27-f1-27-24 ~ # pkcon get-updates   
Getting updates               [=========================]         
Starting                      [=========================]         
Downloading list of packages  [=========================]         
Finished                      [=========================]         
Normal          pacman-mirrorlist-20150719-1.any (core)                         Arch Linux mirror list for use by pacman
Blocked         sudo-1.8.14.p1-1.x86_64 (core)                                  Give certain users the ability to run some commands as root
Normal          xfdesktop-4.12.3-1.x86_64 (extra)                               A desktop manager for Xfce

However the package is installed nevertheless:

root@08-00-27-f1-27-24 ~ # pkcon update
Getting updates               [=========================]         
Finished                      [=========================]         
Downloading list of packages  [=========================]         
Finished                      [=========================]         
Updating packages             [=========================]         
Downloading packages          [=========================]         
Checking signatures           [=========================]         
Installing updates            [=========================]         
Finished                      [=========================]         
root@08-00-27-f1-27-24 ~ # pkcon get-updates
Getting updates               [=========================]         
Downloading list of packages  [=========================]         
Finished                      [=========================]         
There are no updates available at this time.

gnome-packagekit handles this correctly, gnome-software installs blocked packages as well.

Not sure if the client should handle blocked packages or if libpackagekit-glib is to blame.

@hughsie
Copy link
Collaborator

hughsie commented Jul 20, 2015

When you do "pkcon update" we actually do GetUpdates() and then feed the output to UpdatePackages(). We could either do this by filtering the blocked packages at this step, or just by ignoring the blocked packages in the alpm backend.

@eworm-de
Copy link
Collaborator Author

If we filter in alpm backend this results in blocked packages to disappear completly, no? So pkcon get-updates would not list blocked packages at all.

If I understand corretly this problem hits other backends as well, no? So probably a generic solution would be better. I vote for filtering in UpdatePackages(). (Though there is no function whith that name. So we have to touch pk_transaction_update_packages()?)

@hughsie
Copy link
Collaborator

hughsie commented Jul 20, 2015

Well, we could either filter it in the client side or the server side, but the former allows us to have access to the PkInfoEnum value. The slight complication is that pk_client_update_packages_async() takes an array of package_ids, so we can't see the blocked attribute there. I think the right thing to do is probably to fix pk_console_update_system() and the corresponding version in gnome-software too.

@fthiery
Copy link

fthiery commented Jun 29, 2018

Any workaround ? Does packagekit support it's own ignorelist in e.g. a local file ?

@Tooniis
Copy link

Tooniis commented Aug 6, 2020

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants