dnf: Run subscription-manager sync before refreshing metadata #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, libdnf has a bunch of bugs in the repo reloading. I think we need to do dnf_repo_loader_get_repos() after the subscription manager call to force it to correctly reload, similar to what pk_backend_yum_repos_changed_cb does and also clear the sack cache etc. |
hughsie
force-pushed
the
wip/hughsie/subscription-manager
branch
from
6c2a279
to
376a431
Compare
kalev
approved these changes
Oct 9, 2018
|
Why didn't we use librhsm here? |
|
I thought that was dead? The explicit exec was what the subscription manager team wanted us to do. |
|
That's news to me, since libdnf still uses it, and there's a PR to convert its usage into a passive runtime plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.