Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't recognize process.env["string"] #20

Closed
monsanto opened this issue Feb 25, 2015 · 3 comments
Closed

Doesn't recognize process.env["string"] #20

monsanto opened this issue Feb 25, 2015 · 3 comments

Comments

@monsanto
Copy link
Contributor

Example in the wild: https://github.com/petkaantonov/bluebird/blob/261b65805a71deaf37ad48b3cacb71ab7cedd97a/src/debuggability.js#L12

@yoshuawuyts
Copy link
Collaborator

Though doing process.env['some_env'] with hard coded strings is considered bad practice, this is probably something envify would want to catch nevertheless. @monsanto would you be willing to create a PR that implements this?

@zertosh
Copy link
Collaborator

zertosh commented Mar 16, 2015

Published as envify@3.4.0

@zertosh zertosh closed this as completed Mar 16, 2015
@mbrevda
Copy link

mbrevda commented Jan 3, 2016

On the 'bad practice' note, I actually have a great use case: I have a pretty large multidimensional object that I want exposed to envify. Using strings + flat allows simple and easy access to the entire object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants