Switching translator to Google

[joenas]

Hey there and thanks for an awesome app!

I noticed this when trying to use the TranslatorAgent:

DataMarket and Data Services are being retired and will stop accepting new orders after 12/31/2016. Existing subscriptions will be retired and cancelled starting 3/31/2017. Please reach out to your service provider for options if you want to continue service.

Any plans on switching service, to for example Google Translate? If I find some spare time, I might start implementing it if there's interest.

Also, the current Agent doesn't work... 😄

no implicit conversion of nil into String
/app/app/models/agents/translation_agent.rb:44:in `+'
/app/app/models/agents/translation_agent.rb:44:in `translate'

which seems to be because access_token is nil.
I was gonna create an issue about that but since it's being retired anyways I figure no point.

[cantino]

I don't personally use it, but it'd be nice if it worked. We'd gladly accept a PR to fix it.

[Maroo-b]

@cantino it seems that google translate is a paid service ( source )

For free services it seems Yandex the most promising, do you suggest another service to integrate ?

[cantino]

Probably the best solution would be to support multiple translation backends. Would you be interested in working on that?

[Maroo-b]

Absolutely, I suggest that we start by implementing an alternative to the existent solution, it seems that Microsoft Translator is the upgrade for the current implemented solution. (I need to do more checks )
Afterward we can add other backends based on users feedback.

[joenas]

I actually have a working implementation of Google Translate, I just haven't gotten around to write specs...

[cantino]

It'd be great to get both Google and Microsoft in one Agent. @joenas, maybe you can contribute yours and @Maroo-b can add to it?

[Maroo-b]

@cantino that would be interesting I'll wait for @joenas PR.

[joenas]

PR submitted!

[Maroo-b]

should this issue be closed ?

[joenas]

It depends on whether you want to use it for Microsoft/Yandex/whatever too or not I guess?

[Maroo-b]

@joenas thank you for the feedback,
I don't use the translator Agent but if there is a need for another translate API I can submit a PR otherwise I'll check other issues :)

[joenas]

Then I think we should close and move on :D

[cantino]

Agreed! Thanks.