Upgrade Ruby to 2.7 #3055
Merged
Upgrade Ruby to 2.7 #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/huginn/huginn/runs/4672758156 |
knu
force-pushed
the
ruby-2.7
branch
13 times, most recently
from
2c83d38
to
7a9baa7
Compare
|
The test instability reproduced on CircleCI containers, so there has to be something there. I'll investigate further to figure out. |
knu
force-pushed
the
ruby-2.7
branch
8 times, most recently
from
2ba6040
to
a616ad2
Compare
|
super_diff was useful while investigating failing tests, but after experiencing unstable test results, turning it off seems to have fixed the problems. |
|
Hey @knu! What's the status of this PR? |
knu
force-pushed
the
ruby-2.7
branch
2 times, most recently
from
cb96ecc
to
7dd1737
Compare
knu
force-pushed
the
ruby-2.7
branch
4 times, most recently
from
5e5a158
to
0b3ab4b
Compare
|
The unstableness might be caused by caching of the interpolation context. |
I can not really explain why this broke. For some reason the array we use as an index for the interpolation cache was not "hashed" properly and created false hits inn the cache. Explicitly calling `hash` on the array key also calls `hash` on elements and properly caches the data.
knu
force-pushed
the
ruby-2.7
branch
2 times, most recently
from
c6dc65e
to
1c920b7
Compare
- em-http-request 1.1.7 - google-protobuf 3.21.5 - jmespath 1.6.1 - nokogiri 1.13.8 - rack 2.2.4 - rails 6.0.5.1
|
Now that the test flakiness has been fixed, it's time to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update Ruby to 2.7 before we can look to update to Ruby 3.x.
Currently, Ruby 2.7 builds are so flaky and tests are randomly failing whereas no failures are seen with Ruby 2.6.Solved!