Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore subdirs in the dropbox watch agent #3210

Merged
merged 1 commit into from Apr 23, 2023
Merged

fix: ignore subdirs in the dropbox watch agent #3210

merged 1 commit into from Apr 23, 2023

Conversation

bronislav
Copy link
Contributor

Dropbox watch agent fails when subdirectory exists in the directory to watch. This is happens because directory object does not have rev field.

Filter out subdirs to make agent work as expected.

Fixes #2888

@bronislav
fix: ignore subdirs in the dropbox watch agent
91cd43a 
Dropbox watch agent fails when subdirectory exists in the direcroty to
watch. This is happens because directory object does not have `rev`
field.

Filter out subdirs to make agent work as expected.

Fixes huginn#2888
knu
knu approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but as I'm not a user of the DropboxWatchAgent I want to hear from @dsander who has once committed to this agent.

dsander
dsander approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I haven't used the Agent in a long time but the fix looks right to me.

@dsander dsander merged commit 7b61253 into huginn:master Apr 23, 2023
@bronislav bronislav deleted the bugfix/ignore-subdirs-in-dropbox-watch branch April 25, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu approved these changes

@dsander dsander dsander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropbox Watch Agent fails on folders with subfolders
3 participants
@bronislav @knu @dsander