Handle file permissions in a cleaner way while building Docker images #3238
Conversation
knu
commented
Mar 19, 2023
knu
commented
- Use COPY --chown wisely
- Switch USER earlier so that generated files are owned by the user
- Use COPY --chown wisely - Switch USER earlier so that generated files are owned by the user
There was a problem hiding this comment.
Looks a lot cleaner! The changes make sense to me, but permissions can be sneaky. I haven't used it in a long time, but https://github.com/huginn/huginn_docker_specs used to be pretty good in catching regressions, can you check if everything still works with it?
| COPY --chown="$UID:0" vendor/gems/ /app/vendor/gems/ | ||
|
|
||
| ARG ADDITIONAL_GEMS= | ||
| ENV ADDITIONAL_GEMS=$ADDITIONAL_GEMS |
There was a problem hiding this comment.
Nice idea, this allows one to bake agent gems into their docker image to avoid the additional bundle install time at startup?
There was a problem hiding this comment.
Yes, actually I didn't notice that the startup process ran bundle install, and building my own Docker image has been how I build and use Huginn, and thought this should be everybody's option. 😊
|
I have updated the docker specs repository and ran them against this PR, everything is still green 🎉 Also noticed that this brings down the image sizes again, great job! |
|
@dsander Thanks for that! I tried to update the specs but had a hard time fixing them. 😆 |
