Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sanity_check if APP_SECRET_TOKEN is defined #3258

Merged
merged 1 commit into from May 6, 2023
Merged

Conversation

knu
Copy link
Member

@knu knu commented May 4, 2023

Heroku is not the only running platform where environment variables are set outside of .env files, and APP_SECRET_TOKEN should be a good choice to determine if the environment is properly configured because bin/pre_runner_boot.rb already uses this variable to decide whether to call Dotenv.load.

@knu knu requested a review from dsander May 4, 2023 19:29
Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me, thank you! I wonder why I have never run into this problem, I don't set the CI environment variable in my docker deployment.

@knu knu merged commit 5d90493 into master May 6, 2023
14 checks passed
@knu knu deleted the gemfile_sanity branch May 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants