Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Faraday to 1.x #3259

Merged
merged 2 commits into from May 12, 2023
Merged

Upgrade Faraday to 1.x #3259

merged 2 commits into from May 12, 2023

Conversation

knu
Copy link
Member

@knu knu commented May 4, 2023

The latest master branch of tubmlr_client has faraday 1.x as a dependency, so we no longer need to use a fork.

Base automatically changed from ruby-3.2 to master May 9, 2023 07:26
knu added 2 commits May 9, 2023 16:32
The latest master branch of tubmlr_client has faraday 1.x as a dependency, so we no longer need to use a fork.
@knu knu marked this pull request as ready for review May 9, 2023 07:52
@knu knu requested a review from dsander May 9, 2023 07:53
@knu
Copy link
Member Author

knu commented May 9, 2023

I just started running this in my instance. I don't think Faraday changed much in our usage, so hopefully I won't see any trouble with this.

Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't have time to deploy it on my system but also haven't seen any breaking changes between 0.9 and 1.0 on other projects.

@knu
Copy link
Member Author

knu commented May 12, 2023

My agents have been running fine without a problem. 😊

@knu knu merged commit 2a04d2b into master May 12, 2023
12 checks passed
@knu knu deleted the faraday-1 branch May 12, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants