Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option to DelayAgent: emit_interval #3301

Merged
merged 1 commit into from Jul 23, 2023
Merged

Conversation

knu
Copy link
Member

@knu knu commented Jul 16, 2023

This specifies the interval in seconds between emitting events.

The events_order option is fixed so that it works without the max_emitted_events option.

@knu knu requested a review from dsander July 16, 2023 16:09
This specifies the interval in seconds between emitting events.

The `events_order` option is fixed so that it works without the `max_emitted_events` option.
@knu knu force-pushed the delay_agent_emit_interval branch from a45c85c to fda850f Compare July 17, 2023 14:51
Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! What is your use case, avoiding rate limiting on the receiving end?

@knu
Copy link
Member Author

knu commented Jul 23, 2023

@dsander Yes, and to make sure that a series of events are processed in (mostly chronological) order without worrying about race condition.

@knu knu merged commit 2d5fcaf into master Jul 23, 2023
14 checks passed
@knu knu deleted the delay_agent_emit_interval branch July 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants