-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow agents to attach files to events #433
Comments
Hey @andrewcurioso, I like this idea. How should the binary data be stored? For a Huginn deployment, you can't write to disk, so you need to use something like S3. For other deployments, disk might be fine. How large files do you think make sense to support? Small files can be serialized in the DB. |
cc @cantino I can thing of three possible deployment configurations (there are likely more):
Did you mean to say file upload is not possible on Heroku deployments or did you actually mean to say Huginn? If you meant Huginn there might be some background I'm missing. I would think that we could have helper methods that return objects for reading and writing (these are just examples): That way for filesystem configurations it could return a new instance of Then there would just need to be a function to get the URL of the new attachment so that it can be included in the emitted event. I'm going under the assumption that Huginn will assign a non-conflicting filename for each attachment. Disclaimer: I'm just thinking out-loud. |
You're right @andrewcurioso, I definitely meant Heroku, which has a read-only file system. |
@cantino If there are no objections I'd like to try to implement this one myself. |
By all means! |
"As a user, I'd like to be able to automatically send a file in the event that longer than 'expected_update_period_in_days' passes for a particular agent." Incidentally, being able to download a file from an arbitrary link stored in the agent's configuration would be handy. |
I think it would be useful to be able to attach files to an event. It would open Hugann up to a whole new level of integration.
Example user stories that this would open up the possibility for:
The text was updated successfully, but these errors were encountered: