-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request about section Experiences (show logo company) #871
Comments
I think we should do the same to the education section, showing logos of colleges and schools. |
I'm agree @BernatBC. We should do the same to the education section. But it must be tested to have an preview. |
Sure, but I'll need some help with it |
Okay. I will give a try. No promise on the timeline. |
I don't think a presentation like linkedin would be suitable. The position of the logo requires square images. Not all companies or schools necessarily have a square logo, very often it is rectangular. The solution I proposed, I have seen it elsewhere and it works. Square and rectangular case. |
That make sense. Your example one looks good @niltied. We can go with it. |
Sure. Go ahead @BernatBC . |
+1. @hossainemruz is OK too, go ahead @BernatBC. It's OK for me. You confirm that it's OK for |
@niltied Yes, you can check the Pull Request to see how it looks for the |
I saw @BernatBC I can't wait to test it on my site ! |
Hi @hossainemruz
After all the work done on Toha v4, I think, it's time to make evolution on the frontend of Toha.
So, first, i closed my initial issue #827. Because, i'm not satisfy about the content of this issue, and I'm not an developer. I feel not be able to dev this feature. So, i make this new issue with more explications here for any people.
Definition of Ready
I would like to have the possibility to add the logos of the companies where I worked in the
Experience
section. I've put an example below that describes the imagined presentation, and I've also added some sample code that might meet this need.I post the code showed in the image to make it clearer.
The idea is :
experience.yaml
file.asset/sections/experiences/
directory.Definition of Done
What do you think ?
The text was updated successfully, but these errors were encountered: