Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master activate switch does not correctly disable the plugin #52

Closed
keedav opened this issue Oct 20, 2021 · 5 comments
Closed

Master activate switch does not correctly disable the plugin #52

keedav opened this issue Oct 20, 2021 · 5 comments
Assignees
Labels
bug Something isn't working ready Issue is fixed and ready to be deployed
Milestone

Comments

@keedav
Copy link

keedav commented Oct 20, 2021

After disabling the "Master activate switch", the wire styling reverts to the unreal default style, but in the Blueprint editor all wire including value wires becomes white, and every wire gets a white arrow to its end.

Screenshot

To Reproduce

  1. Install the plugin from the marketplace to a fresh project with no other plugins
  2. Open Editor Preferences -> Electronic Nodes Plugin -> disable Master Activate switch
  3. Restart the editor
  4. Open or create a Blueprint event graph. Note that the wires are curving as if the plugin had been disabled, but all wires, including value wires became white, and every wire got a white arrow to its end

Expected behavior
Pressing the "Master Activate" switch should act as its description. It should deactivate the whole plugin, and the wire styles should completely revert to the unreal engine default.

Environment:

  • Unreal Engine: 4.27.0
  • Plugin Version: 3.5
  • Operating System: Windows 64bits

Additional context
The "Master Activate" switch correctly worked for in our previous project where the Electronic Nodes version 2.6 was installed. We are working in a team, and some members prefer the Unreal styling while other the Electronic Nodes styling. Previously you were able to disable locally the plugin with "Master Activate" without needing to disable the plugin in .uproject.

Workaround
You have to disable "Use Hot Patch" before pressing "Master Activate", because "Use Hot Patch" option becomes grayed out when "Master Activate" is disabled. With "Use Hot Patch" disabled, "Master Activate" works correctly.

@keedav keedav added bug Something isn't working pending Pending approval labels Oct 20, 2021
@hugoattal
Copy link
Owner

Thank you for reporting this issue!

Yes, the "Use Hot Patch" feature actually modify the engine in a non-reversible way (unless restarting it), resulting in this white wires when the plugin is disabled.

But the Master Activate should disable the hotpatch as well. I'll try to reproduce and fix this quickly.

@hugoattal hugoattal removed the pending Pending approval label Oct 20, 2021
@hugoattal hugoattal self-assigned this Oct 20, 2021
@hugoattal hugoattal added the ready Issue is fixed and ready to be deployed label Apr 15, 2022
@hugoattal hugoattal added this to the 3.6 milestone Apr 18, 2022
@hugoattal
Copy link
Owner

Fixed by 3.6 !

@wxz97121
Copy link

Hi, I'm using UE4.27 and Electronic Node Plugin, so the Epic Games Store install 3.5 for me.
But this bug also bothers me a lot. Would you mind telling how to modify 3.5 code to fix this issue?
Or is there any way to force Epic Game Store download 3.6 for me? Is 3.6 compatible with UE4.27?

@hugoattal hugoattal reopened this Oct 12, 2022
@hugoattal
Copy link
Owner

@wxz97121 Soooo, for whatever reason 3.6 only made it to UE5.0... I'm sorry for this, I didn't notice. I'm updating the 4.26 and 4.27 version to 3.6. It should be available in ~24h.

(In the meantime, if you really need it now, you need UE5.0 to download EN3.6)

@wxz97121
Copy link

@wxz97121 Soooo, for whatever reason 3.6 only made it to UE5.0... I'm sorry for this, I didn't notice. I'm updating the 4.26 and 4.27 version to 3.6. It should be available in ~24h.

(In the meantime, if you really need it now, you need UE5.0 to download EN3.6)

Thanks! I will check it out~ 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready Issue is fixed and ready to be deployed
Projects
None yet
Development

No branches or pull requests

3 participants