clj-ssh/download: fix :recursive and :preserve flags. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursive still doesn't work correctly: clj-ssh writes every file into the same output.
hugoduncan
added a commit
that referenced
this pull request
Mar 17, 2016
clj-ssh/download: fix :recursive and :preserve flags.
| (string/join " " remote-paths)) | ||
| _ (println cmd) |
There was a problem hiding this comment.
I think this println may not be wanted?
There was a problem hiding this comment.
@rborer thanks for pointing that out. I'll cut another release without this.
There was a problem hiding this comment.
Ah, yes, that looks like my mistake. Sorry bout that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for :recursive and :preserve called (map) on a kv map without destructuring the pairs, resulting in an arity mismatch exception. This patch pulls out the keys so we can pass the -p and -r flags to scp correctly. Recursive is still broken, however--it verifies the output path is a directory, then opens it as a file and clobbers it with each source file in turn.