Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow latest playwright-core #658

Merged
merged 1 commit into from
May 2, 2024

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented May 1, 2024

The last playwright-core release has the latest Firefox which finally has support for WebTransport serverCertificateHashes.

Unpins playwright-core version to be able to test with the latest browser releases.

I'm not sure why this was pinned in the first place - @hugomrdias any ideas? Would you prefer it pinned to 1.43.1 (the latest at the time of writing)?

@achingbrain achingbrain force-pushed the fix/allow-latest-playwright-core branch 2 times, most recently from 91c7b09 to 371bb3d Compare May 2, 2024 12:09
Unpins playwright-core version to be able to test with the latest browser releases.
@achingbrain achingbrain force-pushed the fix/allow-latest-playwright-core branch from 371bb3d to 3849e02 Compare May 2, 2024 12:10
@hugomrdias
Copy link
Owner

dunno i think, i saw some breakage even in patch and minors cause i use internals to avoid the default download all browsers logic.

@hugomrdias hugomrdias merged commit 4c3f7d6 into master May 2, 2024
6 checks passed
@hugomrdias hugomrdias deleted the fix/allow-latest-playwright-core branch May 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants