add owasp zsc api

[Ali-Razmjoo]

Hello, I'm trying to add an API for generating shellcode, But it getting me some error while adding command line "shellcode zsc" which you can see in line 2701 [i write there] at here
https://github.com/Ali-Razmjoo/gef/commit/04cb3787abd4006715b2691aa9ccecbc00242a24
what am i missing?

[hugsy]

By just a quick look at it, there seems to be an error in your code:
https://github.com/Ali-Razmjoo/gef/blob/04cb3787abd4006715b2691aa9ccecbc00242a24/gef.py#L2129

There is no global function zsc() defined. Did you mean to call self.zscget()?

[Ali-Razmjoo]

sorry it was little mistake there, but error was not for that
I change some but still have this error [!] Failed to loadshellcode zsc: unsupported operand type(s) for +=: 'NoneType' and 'str'
https://github.com/Ali-Razmjoo/gef/commit/66765188aa99f55264845892810e04d25227f1ab
seems it cannot import shellcode zsc or something

[hugsy]

This is because you didn't add a description to your new command.
For example, if you change it with:

class ShellcodeGenerateCommand(GenericCommand):
    """My awesome command"""
    _cmdline_ = "shellcode zsc"
    _syntax_  = _cmdline_
    def do_invoke(self, argv):
        if len(argv) is 0:
            self.zscgenerate()

I'm pretty sure it will work.

That's because gef builds dynamically the content of the help menu, and uses the __doc__ param which is implicitly defined when you add a description to your class.

[Ali-Razmjoo]

Thanks for your help, fixed