Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register_external_context_pane shouldn't change context.layout #1010

Closed
MrQubo opened this issue Oct 8, 2023 · 2 comments
Closed

register_external_context_pane shouldn't change context.layout #1010

MrQubo opened this issue Oct 8, 2023 · 2 comments

Comments

@MrQubo
Copy link

MrQubo commented Oct 8, 2023

register_external_context_pane() automatically appends pane name to context.layout.

I think that register_external_context_pane() shouldn't modify context.layout. Users can set the layout themselves or the code calling register_external_context_pane could do so.

Just remove this line:

gef/gef.py

Line 9607 in 5927df4

gef.config["context.layout"] += f" {corrected_settings_name}"

Seems like issue template thing is broken for me. Clicking "Submit new issue" just does nothing.

@hugsy
Copy link
Owner

hugsy commented Nov 1, 2023

register_external_context_pane() automatically appends pane name to context.layout.

It's debatable: I'd argue that if you go to the point of writing your own pane(s) it means you intend to use them so automatically adding them makes sense.

Did this break something for you (aside from the new layout appearance)?

Seems like issue template thing is broken for me. Clicking "Submit new issue" just does nothing.

Weird 🤔

@hugsy
Copy link
Owner

hugsy commented Nov 1, 2023

Also, moving this into discussion, as it's not a bug

Repository owner locked and limited conversation to collaborators Nov 1, 2023
@hugsy hugsy converted this issue into discussion #1015 Nov 1, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants