New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should remove node_modules in root directory #18

Closed

a60814billy opened this issue Nov 28, 2019 · 1 comment

a60814billy commented Nov 28, 2019 •

edited

In general, we don't put node_modules to SCM, because it can restore by npm install command.

By the way, I only see package-lock.json in project root directory, and package.json is missing. That weirds me out.

The text was updated successfully, but these errors were encountered:

Owner

humank commented Jul 25, 2020

@a60814billy Thanks for the feedback, sorry i missed this issue for a long while, for now this issue has been resolved.

humank closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment